Fix exception types for jsonschema._format #7990
Conversation
The annotated type for the `raises` argument on format checkers was
Exception | tuple[Exception, ...]
when it should read
type[Exception] | tuple[type[Exception], ...]
| @@ -2,14 +2,15 @@ from collections.abc import Callable, Iterable | |||
| from typing import Any, TypeVar | |||
|
|
|||
| _F = TypeVar("_F", bound=Callable[..., Any]) | |||
| _RaisesType = type[Exception] | tuple[type[Exception], ...] | |||
There was a problem hiding this comment.
You've hit a known mypy bug (python/mypy#11098, python/mypy#12392) in its handling of PEP-604 type aliases. The workaround is to use the old syntax (Union) here instead. The rest of our CI won't complain about it in this instance.
There was a problem hiding this comment.
Ah, easy enough -- I'll have that done in just a second.
Also, thanks to you and everyone on typeshed for being super responsive! It makes it very easy to contribute. ❤️
There was a problem hiding this comment.
thanks to you and everyone on typeshed for being super responsive! It makes it very easy to contribute. ❤️
I'm very glad to hear that! Also, don't beat yourself up too much about the regressions — it's nearly inevitable if you're adding annotations to stubs that currently don't have many type hints at all. One way we could work to reduce these in the future, however, would be to add more open-source projects using types-jsonschema to mypy_primer (https://github.com/hauntsaninja/mypy_primer)
There was a problem hiding this comment.
I'll give that a shot. check-jsonschema is where I'm doing my own work.
And there was a PR from the maintainers of https://github.com/matrix-org/synapse , so perhaps I can integrate that as well. I'll have to see how they have mypy setup, of course.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
|
Sorry, my bad, |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
The annotated type for the
raisesargument on format checkers waswhen it should read
This is a mistake I introduced in #7950 . So far, there have been two or three issues found with those changes, depending on how you count. I will try to make smaller changes to
jsonschemastubs in the future to avoid creating this situation again.