Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pyopenssl hints for set_ocsp_server_callback/set_ocsp_client_callback #8371

Merged
merged 2 commits into from Jul 23, 2022
Merged

Fix pyopenssl hints for set_ocsp_server_callback/set_ocsp_client_callback #8371

merged 2 commits into from Jul 23, 2022

Conversation

ShaneHarvey
Copy link
Contributor

@ShaneHarvey ShaneHarvey commented Jul 22, 2022 •
edited

Fixes #8370:

pymongo/pyopenssl_context.py:195: error: Argument "data" to
"set_ocsp_client_callback" of "Context" has incompatible type "_CallbackData";
expected "Optional[bytes]"  [arg-type]
    ...csp_client_callback(callback=_ocsp_callback, data=self._callback_data)

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@ShaneHarvey ShaneHarvey mentioned this pull request Jul 22, 2022
Merged
sobolevn
sobolevn approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I only saw bytes use-cases.

@AlexWaygood AlexWaygood merged commit b47d771 into python:master Jul 23, 2022
@AlexWaygood AlexWaygood mentioned this pull request Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyopenssl Context.set_ocsp_client_callback has incorrect argument types
3 participants
@ShaneHarvey @sobolevn @AlexWaygood