Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete stubs for bleach #9314

Merged
merged 28 commits into from
Feb 21, 2024
Merged

Complete stubs for bleach #9314

merged 28 commits into from
Feb 21, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Dec 1, 2022

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A partial review. I haven't looked at linkifier.pyi or the following files yet.

stubs/bleach/bleach/html5lib_shim.pyi Outdated Show resolved Hide resolved
stubs/bleach/bleach/html5lib_shim.pyi Outdated Show resolved Hide resolved
stubs/bleach/bleach/html5lib_shim.pyi Outdated Show resolved Hide resolved
stubs/bleach/bleach/html5lib_shim.pyi Outdated Show resolved Hide resolved
stubs/bleach/bleach/html5lib_shim.pyi Outdated Show resolved Hide resolved
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part two of my review!

stubs/bleach/bleach/linkifier.pyi Outdated Show resolved Hide resolved
stubs/bleach/bleach/linkifier.pyi Outdated Show resolved Hide resolved
stubs/bleach/bleach/linkifier.pyi Outdated Show resolved Hide resolved
stubs/bleach/bleach/sanitizer.pyi Outdated Show resolved Hide resolved
stubs/html5lib/html5lib/_inputstream.pyi Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

@AlexWaygood
Copy link
Member

@sobolevn, I've just merged in main and fixed some followup issues post-merge. Are you interested in taking a look at my review, and the remaining CI errors? :)

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

This comment has been minimized.

@JelleZijlstra
Copy link
Member

@Avasam are you still up for updating this PR? Looks like it's pretty close but there's a few CI problems to fix.

@Avasam
Copy link
Sponsor Collaborator

Avasam commented Feb 17, 2024

@JelleZijlstra Yes I am, since we haven't heard back from sobolevn on this. I'll take a look at it in the coming days.

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done an extensive re-review, but this all looks good to me except for one comment about a comment

stubs/bleach/@tests/stubtest_allowlist.txt Outdated Show resolved Hide resolved
@AlexWaygood
Copy link
Member

Thanks so much for finishing this off @Avasam!

This comment has been minimized.

This comment has been minimized.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

This comment has been minimized.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood changed the title Mark bleach as complete Complete stubs for bleach Feb 21, 2024
@AlexWaygood AlexWaygood merged commit a209500 into python:main Feb 21, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants