Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stubsabot] Make google-cloud-ndb a namespace package; bump pinned version to 2.0.* #9339

Merged
merged 3 commits into from Dec 7, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 7, 2022

Release: https://pypi.org/pypi/google-cloud-ndb/2.0.0
Homepage: https://github.com/googleapis/python-ndb
Diff: googleapis/python-ndb@v1.12.0...v2.0.0

Stubsabot analysis of the diff between the two releases:

  • 0 public Python files have been added.
  • 0 files included in typeshed's stubs have been deleted.
  • 6 files included in typeshed's stubs have been modified or renamed: google/cloud/ndb/_cache.py, google/cloud/ndb/_datastore_api.py, google/cloud/ndb/_datastore_query.py, google/cloud/ndb/client.py, google/cloud/ndb/key.py, google/cloud/ndb/model.py.
  • Total lines of Python code added: 170.
  • Total lines of Python code deleted: 145.

If stubtest fails for this PR:

  • Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
  • Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI

Release: https://pypi.org/pypi/google-cloud-ndb/2.0.0
Homepage: https://github.com/googleapis/python-ndb
Diff: googleapis/python-ndb@v1.12.0...v2.0.0

Stubsabot analysis of the diff between the two releases:
 - 0 public Python files have been added.
 - 0 files included in typeshed's stubs have been deleted.
 - 6 files included in typeshed's stubs have been modified or renamed: `google/cloud/ndb/_cache.py`, `google/cloud/ndb/_datastore_api.py`, `google/cloud/ndb/_datastore_query.py`, `google/cloud/ndb/client.py`, `google/cloud/ndb/key.py`, `google/cloud/ndb/model.py`.
 - Total lines of Python code added: 170.
 - Total lines of Python code deleted: 145.

If stubtest fails for this PR:
- Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
- Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI
@AlexWaygood AlexWaygood closed this Dec 7, 2022
@AlexWaygood AlexWaygood reopened this Dec 7, 2022
@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 7, 2022

We could consider deleting google/__init__.pyi from the stubs for this stubs release, since it's a major version bump. google-cloud-ndb is a namespace package at runtime but not in typeshed, meaning @erictraut has to manually delete google/__init__.pyi from these stubs every time he syncs typeshed: microsoft/pyright#2113 (comment). Now that --namespace-packages is the default for mypy, it should be minimally disruptive for mypy users to delete google/__init__.pyi.

@hauntsaninja
Copy link
Collaborator

Do it! Worked well enough with protobuf!

@AlexWaygood AlexWaygood changed the title [stubsabot] Bump google-cloud-ndb to 2.0.* [stubsabot] Make google-cloud-ndb a namespace package; bump pinned version to 2.0.* Dec 7, 2022
@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 7, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 0eecaf4 into main Dec 7, 2022
@AlexWaygood AlexWaygood deleted the stubsabot/google-cloud-ndb branch December 7, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants