Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tagMap & typeMap in pyasn1 encoder/decoder #9471

Closed
wants to merge 1 commit into from

Conversation

Avasam
Copy link
Sponsor Collaborator

@Avasam Avasam commented Jan 6, 2023

Required for #9470
These are meant to be exported (and are actually used) as a helper mapping of types for specific encoder/decoder

To avoid very large unions and complex overloads, I've kept only the base types.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Avasam Avasam mentioned this pull request Jan 6, 2023
@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 7, 2023

Oh, I guess stubtest didn't flag these as missing because of the fact that the runtime defines __all__, and these are omitted from __all__ at runtime. But if our ldap3 stubs need them, that's a good enough reason to include them here!

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 7, 2023

Actually, on second thought, I'm really not sure we should add these symbols to the stub. They're all marked with comments in the source code saying that they're deprecated aliases, and none of them are included in __all__. I think there's an alternative solution to the issue with the ldap3 stubs -- see my comments here: #9470 (comment)

@AlexWaygood AlexWaygood closed this Jan 8, 2023
@Avasam Avasam deleted the pyasn1-stubs branch February 29, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants