Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed spec change about TypeGuard/bool compatibility #1637

Merged
merged 4 commits into from Feb 29, 2024
Merged

Proposed spec change about TypeGuard/bool compatibility #1637

merged 4 commits into from Feb 29, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra mentioned this pull request Feb 21, 2024
Closed
5 tasks
srittau
srittau reviewed Feb 21, 2024
View reviewed changes
docs/spec/narrowing.rst Outdated Show resolved Hide resolved
gvanrossum
gvanrossum approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec update LGTM.

@JelleZijlstra JelleZijlstra marked this pull request as ready for review February 29, 2024 00:16
@JelleZijlstra JelleZijlstra merged commit e08290b into python:main Feb 29, 2024
4 checks passed
@JelleZijlstra JelleZijlstra deleted the tgbool branch February 29, 2024 00:20
@JelleZijlstra JelleZijlstra mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau left review comments

@erictraut erictraut erictraut left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JelleZijlstra @srittau @gvanrossum @erictraut