Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public and document GenericMeta #340

Merged
merged 2 commits into from Jan 18, 2017

Conversation

ilevkivskyi
Copy link
Member

Fixes #335

I added GenericMeta to __all__ and added docstrings to GenericMeta and GenericMeta.__new__ following the discussion in the issue.
I decided not to describe __origin__ and friends in docstrings. Instead, I just added a comment at the place where they are first used.

@gvanrossum
Copy link
Member

Harmless though this is I think it's also not critical to get it into 3.6.0. People who want it can use from typing import GenericMeta, which works regardless.

@gvanrossum gvanrossum merged commit 093ad88 into python:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants