Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the extension tests using the current Python executable #615

Merged
merged 1 commit into from Feb 14, 2019
Merged

Run the extension tests using the current Python executable #615

merged 1 commit into from Feb 14, 2019

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Feb 14, 2019

Not whatever "python" might be.

@mr-c
Run the tests using the current Python executable
946c9c2 
Not whatever "python" might be.
ilevkivskyi
ilevkivskyi approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. These tests are usually run with CI or within a virtual environment. But I don't see any harm in making tests work in other conditions.

@ilevkivskyi ilevkivskyi merged commit 1f49677 into python:master Feb 14, 2019
@mr-c mr-c deleted the extensions_use_system_exec branch February 14, 2019 10:38
@mr-c
Copy link
Contributor Author

mr-c commented Feb 14, 2019

@ilevkivskyi Thanks! This was needed for the Debian package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mr-c @ilevkivskyi @the-knights-who-say-ni