Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime-checkable protocol tests: Use @runtime_checkable, not @runtime #134

Merged

Conversation

AlexWaygood
Copy link
Member

The original name for this decorator was @runtime, and so that's the name that's currently used in most of the tests for this decorator in typing_extensions. However, the name was changed to @runtime_checkable before the decorator was added to the typing module, and so the old @runtime name doesn't appear anywhere in the docs for the typing module. The @runtime name exists in typing_extensions only for backwards compatibility.

Let's change the usages in our test suite to use the more modern name, so that it's less confusing and more consistent with typing.

@JelleZijlstra JelleZijlstra merged commit 0fc655d into python:main Apr 10, 2023
15 checks passed
@AlexWaygood AlexWaygood deleted the runtime-checkable-not-runtime branch April 10, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants