Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport tests of Union + Literal from CPython #152

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

sobolevn
Copy link
Member

This PR is the backport of two my CPython's PR:

  1. gh-103592: Add tests of Literal with Enum and Union of Literals cpython#103706 (merged)
  2. gh-103746: Test types.UnionType and Literal types together cpython#103747 (not merged yet)

Sorry, I often forget to do the backport when I write new tests.

@sobolevn
Copy link
Member Author

sobolevn commented Apr 24, 2023

Hm, I need to ignore | tests for older versions.

@JelleZijlstra
Copy link
Member

Thanks! Let's wait until python/cpython#103747 is merged in case there are changes.

@sobolevn
Copy link
Member Author

It is merged now :)

@JelleZijlstra JelleZijlstra merged commit 0b8de38 into python:main Apr 24, 2023
15 checks passed
ShaneMurphy2 pushed a commit to ShaneMurphy2/typing_extensions that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants