Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 3.12 #173

Merged
merged 6 commits into from
May 26, 2023
Merged

Support 3.12 #173

merged 6 commits into from
May 26, 2023

Conversation

JelleZijlstra
Copy link
Member

No description provided.

@JelleZijlstra
Copy link
Member Author

I guess this still runs alpha 7, which doesn't have a lot of stuff we need. Let's try again after beta 1 is released.

@AlexWaygood
Copy link
Member

AlexWaygood commented May 22, 2023 •
edited

We could use https://github.com/deadsnakes/action to test with a nightly build in CI. Or, yeah, we could just wait a few days :)

@AlexWaygood
Copy link
Member

Guessing it'll be a few more days before actions/setup-python starts using 3.12b1 for 3.12-dev

@JelleZijlstra
Copy link
Member Author

What, it was released like two hours ago :D

I think I'll cut the 4.6.0 release tonight without waiting for this, after manually confirming that things work on current 3.12.

@tmke8
Copy link

tmke8 commented May 24, 2023

Seems 3.12-beta1 was just made available (3 hours ago): https://github.com/actions/python-versions/releases/tag/3.12.0-beta.1-5071360807

@JelleZijlstra JelleZijlstra reopened this May 24, 2023
@JelleZijlstra
Copy link
Member Author

Looks like we're still getting alpha7

@tmke8
Copy link

tmke8 commented May 24, 2023

Sorry, it seems the manifest needs to be updated still:

@AlexWaygood AlexWaygood reopened this May 25, 2023
@AlexWaygood
Copy link
Member

We're now getting 3.12-beta1 in CI, but the new test that was added in #188 is failing on 3.12.

@AlexWaygood
Copy link
Member

We're now getting 3.12-beta1 in CI, but the new test that was added in #188 is failing on 3.12.

It's a bug in CPython. Writing an issue up now.

@AlexWaygood
Copy link
Member

AlexWaygood commented May 25, 2023 •
edited

We're now getting 3.12-beta1 in CI, but the new test that was added in #188 is failing on 3.12.

It's a bug in CPython. Writing an issue up now.

@AlexWaygood AlexWaygood mentioned this pull request May 26, 2023
Merged
@AlexWaygood
Copy link
Member

Following 5d51455, everything should now be green on 3.12 if you merge in main

AlexWaygood
AlexWaygood reviewed May 26, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -98,7 +98,7 @@
as a class rather than a function). This allows user-defined `NewType`s to be
pickled. Patch by Alex Waygood.
- Fix tests and import on Python 3.12, where `typing.TypeVar` can no longer be
subclassed. Patch by Jelle Zijlstra.
subclassed. Add explicit support for Python 3.12. Patches by Jelle Zijlstra.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Add explicit support for 3.12" bit needs to be moved to the top of the Changelog

@srittau srittau merged commit 3e04a2d into python:main May 26, 2023
16 checks passed
@JelleZijlstra JelleZijlstra mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JelleZijlstra @AlexWaygood @tmke8 @srittau