-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Zones #53
Comments
Looks like #51 and the 2022.2 release might address the Europe/Kiev vs. Europe/Kyiv issue. I don't see Hanoi mentioned in the PR though? What's the expected release date of 2022.2? StackOverflow discussion of Hanoi: https://stackoverflow.com/a/73333278/402560 |
I'm kind of amazed that in 2 days people have managed to pick up 2022b, start using it with Be aware that whatever process is relying on this seems likely to be fragile, since it doesn't seem to be accounting for tzdata version differences. Even though I plan to make a |
It seems that |
I've released version 2022.2, which solves your Europe/Kyiv problem. IIRC correctly it was a deliberate choice to not ship backzone, because most systems won't be shipping backzone, so I think it's unlikely that we'll fix the Asia/Hanoi issue at the moment. Maybe we can have a separate package like |
Its breaking netbox installs and django packages which is why its being picked up on,
netbox-community/netbox#9986
|
I chose to include backzone in pytz in an attempt to head off problems:
This upstream change modifies some of the pre-1970 transitions in obscure ways that almost zero users will actually care about and where quite likely dubious in any case. Such as the times pre-1970 when Belfast was not on London time or when Amsterdam switched from being 20 minutes ahead of GMT to GMT. I think I'm going to re-release pytz without backzone, before anyone starts depending on it. Changes to historical timezones has always happened in the upstream database, and normally they are called corrections (which only causes breakage if you area storing wallclock times rather than UTC timestamps). (and I should look into switching pytz to use tzdata for the database instead of its own copy, in the interests of transitioning to the future) |
Per python/tzdata#53 (comment) I chose to include backzone in pytz in an attempt to head off problems: Changes to past timestamps Finish moving to 'backzone' the location-based zones whose timestamps since 1970 are duplicates; adjust links accordingly. This change ordinarily affects only pre-1970 timestamps, and with the new PACKRATLIST option it does not affect any timestamps. In this round the affected zones are Antarctica/Vostok, Asia/Brunei, Asia/Kuala_Lumpur, Atlantic/Reykjavik, Europe/Amsterdam, Europe/Copenhagen, Europe/Luxembourg, Europe/Monaco, Europe/Oslo, Europe/Stockholm, Indian/Christmas, Indian/Cocos, Indian/Kerguelen, Indian/Mahe, Indian/Reunion, Pacific/Chuuk, Pacific/Funafuti, Pacific/Majuro, Pacific/Pohnpei, Pacific/Wake and Pacific/Wallis, and the affected links are Arctic/Longyearbyen, Atlantic/Jan_Mayen, Iceland, Pacific/Ponape, Pacific/Truk, and Pacific/Yap. This upstream change modifies some of the pre-1970 transitions in obscure ways that almost zero users will actually care about, and where quite likely dubious in any case. Such as the times pre-1970 when Belfast was not on London time or when Amsterdam switched from being 18-20 minutes ahead of GMT to GMT. Changes to historical timezones has always happened in the upstream database, and normally they are called corrections (which only causes breakage if you area storing wallclock times rather than UTC timestamps).
Hanoi and Kyiv zone data is missing and causing pytz to break, and in turn django migrations that use tzdata to break
The text was updated successfully, but these errors were encountered: