Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(preprocessor): inhibit mode while committing #122

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix(preprocessor): inhibit mode while committing #122

merged 1 commit into from
Nov 9, 2023

Conversation

pythonbrad
Copy link
Owner

@pythonbrad pythonbrad commented Nov 8, 2023 •
edited

Fix problem of using a predicate in inhibit mode
resolve #119

@pythonbrad pythonbrad self-assigned this Nov 8, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6798755175

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 98.47%
Changes Missing Coverage Covered Lines Changed/Added Lines %
engine/preprocessor/src/lib.rs 6 8 75.0%
Totals Coverage Status
Change from base Build 6699825092: 0.07%
Covered Lines: 1416
Relevant Lines: 1438
💛 - Coveralls

@pythonbrad
Copy link
Owner Author

The pr has been tested on windows manually. ✅

@pythonbrad pythonbrad merged commit 0e021d1 into main Nov 9, 2023
4 of 5 checks passed
@pythonbrad pythonbrad deleted the patch branch November 9, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pythonbrad pythonbrad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the inhibit mode don't work with predications
2 participants
@pythonbrad @coveralls