Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method POST #187

Closed
grubberr opened this issue Dec 20, 2014 · 3 comments
Closed

method POST #187

grubberr opened this issue Dec 20, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@grubberr
Copy link
Contributor

according to this
https://github.com/pythonforfacebook/facebook-sdk/blob/master/facebook/__init__.py#L233
I see that request method has to select HTTP method POST
if post_args is defined

but I don't see any code which can do this

@theeluwin
Copy link

maybe method='POST' shall affect this line https://github.com/pythonforfacebook/facebook-sdk/blob/master/facebook/__init__.py#L246

@grubberr
Copy link
Contributor Author

Current behaviour in facebook-sdk 0.4.0 from PyPI

G.request(path) - GET request
G.request(path, post args=post args) - POST request

but in facebook_sdk-1.0.0a0
in both cases will be GET request

do I need to provide 'method' param explicitly now ?

@theeluwin
Copy link

how about putting method = "POST" if method is None below this line https://github.com/pythonforfacebook/facebook-sdk/blob/master/facebook/__init__.py#L240 ?
@martey

@martey martey added this to the v1.0.0 milestone Jan 26, 2015
@martey martey self-assigned this Jan 26, 2015
@martey martey added the bug label Jan 26, 2015
@martey martey closed this as completed in 31c4035 Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants