Update imageFeed.js #224
Closed
Update imageFeed.js #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a aewrite of the Image Feed system based on my previous abandoned pull request. The feed: - lets the user filter images based on source node. - groups images from the same run into batches with a visible marker. Additionally, the slider for height as well as two new controls have been moved to the ComfyUI menu. Locking the feed to the left or right has not yet been implemented. Known 'image nodes' are defined in an array, with unrecognised nodes caught via a catch fall filter setting.
|
The big weakness of this implementation is that I haven't found a way to dynamically identify 'image' nodes. There's a 'custom node' fallback, but this is deeply unsatisfying. All feedback is welcome, but feedback on that issue specifically is extra welcome. |
Fixed minor logic bug in execution_start.
Fix divider bar CSS.
Fixed bug I created in legacy getVal's
Fixed custom node button interactions with filter.
Updated getVal so it actually works the way I thought it did.
More bug squashing.
Dealing with other peoples problems.
|
Hey, thanks, would you please be able to split the different parts into their own PRs (probably: batch markers, filtering nodes, ui refactor changes), as its difficult to review with everything all in one. For some early feedback:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (somewhat over the top) rewrite of the Image Feed system based on my previous abandoned pull request.
The feed:
Additionally, the slider for height as well as two new controls have been moved to the ComfyUI menu.
Locking the feed to the left or right has not yet been implemented but I can readd it if its a 'must go' feature.
Known 'image nodes' are defined in an array, with unrecognised nodes caught via a catch fall filter setting. I'm currently looking for a better way to identify 'image' nodes for inclusion in the filter.
Tested on Firefox and Chromium.