Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to requirements-dev.txt #683

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Remove references to requirements-dev.txt #683

merged 1 commit into from
Jun 7, 2020

Conversation

CruiseDevice
Copy link
Contributor

@CruiseDevice CruiseDevice commented Jun 5, 2020 •
edited by palnabarun

Fixes #654

sayanchowdhury
sayanchowdhury approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@sayanchowdhury sayanchowdhury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sayanchowdhury
Copy link
Member

Looks good but I will give @palnabarun the final pass.

palnabarun
palnabarun requested changes Jun 6, 2020
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the change mentioned, looks good to me. 🙂

README.md Outdated Show resolved Hide resolved
@palnabarun
Copy link
Member

@CruiseDevice -- Thank you for your contribution. 👍

Please fix the conflicts.

Note: I edited the PR comment to reflect that merging this with fix #654

@palnabarun
Copy link
Member

@CruiseDevice -- can you please rebase this branch on top of master instead of merging master to this branch? We avoid merging merge commits.

@ananyo2012
Copy link
Contributor

@palnabarun What is the use of bin/regenerate.sh ? Do we need this anymore ?

@palnabarun
Copy link
Member

@ananyo2012 -- No idea. But, I prefet keeping it for now for sanity.

@palnabarun palnabarun merged commit 01ae9c5 into pythonindia:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayanchowdhury sayanchowdhury sayanchowdhury approved these changes

@palnabarun palnabarun palnabarun approved these changes

@ananyo2012 ananyo2012 ananyo2012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove remaining references to requirements-dev.txt
4 participants
@CruiseDevice @sayanchowdhury @palnabarun @ananyo2012