Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps django version to 2.2 #685

Closed
wants to merge 7 commits into from
Closed

Bumps django version to 2.2 #685

wants to merge 7 commits into from

Conversation

onlinejudge95
Copy link

  • Upgrades Django to 2.2

@onlinejudge95 onlinejudge95 marked this pull request as draft June 6, 2020 07:02
@palnabarun
Copy link
Member

palnabarun commented Jun 6, 2020 •
edited

@onlinejudge95 -- Thank you for starting the work on this. 👍

I know that this is a draft but please keep a note of the following:

  1. Rebase your changes instead of merging master into this branch. This will not have the issue with the merge commits.
  2. Try to follow the commit conventions in: https://chris.beams.io/posts/git-commit/
  3. Please target the PR against django-2.2 branch.

@onlinejudge95 onlinejudge95 changed the base branch from master to django-2.2 June 6, 2020 07:19
@onlinejudge95
Fix breaking changes with django.core.urlresolvers.reverse
45f2651 
Replaces the occurence of `from django.core.urlresolvers import reverse`
with `from django.urls import reverse` since it is a breaking change
introduced in Django 2.0
@onlinejudge95 onlinejudge95 deleted the django-upgrade branch June 6, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onlinejudge95 @palnabarun