Added First Time Speaker field to the create proposal page #710
Conversation
abhishekmishragithub
changed the title
|
@abhishekmishragithub Can you check why travis failed? |
junction/proposals/forms.py
Outdated
| is_first_time_speaker = forms.BooleanField( | ||
| label="First Time Speaker", | ||
| required=False, | ||
| help_text="Please tick, if you are a first time speaker" |
There was a problem hiding this comment.
nitpick: does it sound good to have check instead of tick?
There was a problem hiding this comment.
+1
"check" would sound better.
There was a problem hiding this comment.
I had added check initially, but thought it won't sound good. Let me update that.
There was a problem hiding this comment.
Added, please review 8154280
Not, sure. It seems some nox issue. @palnabarun will you be able to help? |
|
@abhishekmishragithub Linter is complaining. Please run |
|
@abhishekmishragithub -- Thank you for taking this up. One question I had was, should we expose the first time speaker information to the public? Usually, I saw in conferences that this information is just for reviewers. This information may also change the perception of attendees towards the talk and may influence their decision of attending the talk. What I feel is once a talk is selected, every talk is on the same platform and carries equal weight to the conference. With that said, I feel the information should be removed from the proposal view. What do you think? @sayanchowdhury @anistark @ananyo2012 |
Good point. I think it should only be available to reviewers. |
|
Yes should be visible only to reviewers. |
|
Agreed this should only be visible to reviewers. |
| @@ -180,6 +180,13 @@ <h4 class='heading'><b>Speaker Links:</b></h4> | |||
| </div> | |||
| {% endif %} | |||
|
|
|||
| {% if proposal.is_first_time_speaker %} | |||
There was a problem hiding this comment.
Maybe just add the check here, if the logged-in person is a reviewer.
| {% if proposal.is_first_time_speaker %} | ||
| <div class="proposal-writeup--section"> | ||
| <h4 class='heading'><b>First Time Speaker:</b></h4> | ||
| <p> Yes</p> |
There was a problem hiding this comment.
Do we use any library like font-awesome? Instead of yes we can show a ✔️
|
@abhishekmishragithub Can we make the changes requested above and merge this? |
abhishekmishragithub
force-pushed
the
first-time-speaker
branch
from
8154280
to
aeefde9
Compare
- Add `is_first_time_speaker` field in proposal form & model - Update proposals/views.py - Add first time speaker checkbox field in proposals/detail/base.html - Add migration for Proposal model
abhishekmishragithub
force-pushed
the
first-time-speaker
branch
from
2a25ef9
to
adf8ee7
Compare
|
Added suggested changes. |
- Show first time speaker label on proposal page only to author & reviewer - Reorder first time speaker checkbox in proposal form
Fixed in a new commit. Please check. |
Fix for #707
Here are the screenshots :