Add functionality to make content url's private #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palnabarun
force-pushed
the
private-slides
branch
4 times, most recently
from
f3f6d5c
to
7120ad5
Compare
palnabarun
requested review from
sayanchowdhury,
anistark and
abhishekmishragithub
|
@palnabarun Since you have the docker-compose files already ready. Is it possible to push them? I'll then setup the project to test. |
abhishekmishragithub
approved these changes
Aug 1, 2020
|
@sayanchowdhury vide our offline discussion, you can test the changes in Python 3.7 virtual environment easily. |
sayanchowdhury
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
@palnabarun Sure, I did look through the code and it looks good. I haven't tested it locally. Given @abhishekmishragithub already gave a +1 go ahead and merge.
anistark
approved these changes
Aug 3, 2020
palnabarun
force-pushed
the
private-slides
branch
from
207e52d
to
eb71dbd
Compare
The content url if set to private can only be viewed by the author or the reviewer. Fixes #713 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
palnabarun
force-pushed
the
private-slides
branch
from
eb71dbd
to
38ef930
Compare
|
Thank you everyone for reviewing! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content url if set to private can only be viewed by the author or
the reviewer.
Fixes #713