Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements logic for #304 #400

Merged
merged 24 commits into from
Jan 22, 2017
Merged

Conversation

shankisg
Copy link
Contributor

Implements logic for #304

This implementation allows tutor to request number of volunteers required, ranges between 1-5. On click of accept button on workshop details page, the tutor will see a popup for requesting number of volunteers required.

Depending on volunteer requirement, user with usertype volunteer can opt-in as volunteer. Also volunteer will have the ability to opt-out as volunteer.

**For using this feature, we need to add usertype as volunteer in the database.

screenshot from 2017-01-01 00 26 52
screenshot from 2017-01-01 00 27 06
screenshot from 2017-01-01 00 27 20
screenshot from 2017-01-01 00 29 04

vnbang2003 and others added 23 commits September 9, 2016 12:12
Merging Devevelopment to Master Branch
Add report, fixed workshop details page button issue
Added workshop is_active filter in profile
Added is_active filter for profile workshop query
Added is_active filter in graph and count  section of profile
@coveralls
Copy link

coveralls commented Dec 31, 2016

Coverage Status

Coverage decreased (-55.6%) to 35.176% when pulling 98392ee on shankisg:WYE-304 into e6b0c69 on pythonindia:development.

@vnbang2003
Copy link
Contributor

@shankisg Something looks wrong . All test cases are failing . Can you check it ?
Probably easy would be create new branch from development and apply you changes to it.

@shankisg
Copy link
Contributor Author

shankisg commented Jan 4, 2017

@vnbang2003 I will check why the testcases are failing. Quick feedback, it seems the test environment is upgraded to Python3.X, and in number of places it is failing for xrange which is not available in Py3.X

File "/home/travis/build/pythonindia/wye/wye/workshops/forms.py", line 193, in WorkshopVolunteer
    CHOICE_LIST = ((idx, idx) for idx in xrange(0, 6))
NameError: name 'xrange' is not defined

@vnbang2003
Copy link
Contributor

We have been running test on python3.5 for long
Latest check ins:

https://travis-ci.org/pythonindia/wye/builds/187705901
https://travis-ci.org/pythonindia/wye/builds/187705748

@vnbang2003
Copy link
Contributor

vnbang2003 commented Jan 4, 2017

@shankisg I guess you local environment is Python2 and hence you didn't see it failing .
Can you please upgrade to python3.4 + version .
We will be soon migrating wye to version python 3.6 and django 1.10(Branch:pyup-initial-update)

@coveralls
Copy link

coveralls commented Jan 21, 2017

Coverage Status

Coverage decreased (-0.5%) to 90.215% when pulling 839fa75 on shankisg:WYE-304 into e6b0c69 on pythonindia:development.

@vnbang2003 vnbang2003 changed the base branch from development to volunteers-feature January 21, 2017 15:20
@vnbang2003
Copy link
Contributor

@shankisg I have created new branch : volunteers-feature let use this .

@vnbang2003 vnbang2003 merged commit 59483fb into pythonindia:volunteers-feature Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants