Mono Domain Set Config #9

C-SELLERS · 2021-03-10T19:54:49Z

This PR addresses issue #8

In order for Mono to carry out some managed functions it needs to have a config set for the appdomain.
Here is the info from the docs.

Description

Used to set the system configuration for an appdomain

Without using this, embedded builds will get 'System.Configuration.ConfigurationErrorsException: Error Initializing the configuration system. ---> System.ArgumentException: The 'ExeConfigFilename' argument cannot be null.' for some managed calls.

Resource:
Mono Docs

I added the definition for mono_domain_set_config,
and then during initialization I give it a "dummy" if config_file is none.

Nothing else changes and the error no longer reproduces.

C-SELLERS · 2021-03-10T22:25:00Z

Tested using the example in issue #8 in Ubuntu with Mono 5.12 and is passing 👍🏽

Python 3.6.8 |Anaconda, Inc.| (default, Dec 30 2018, 01:22:34) 
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pythonnet import load
rence
AddReference("RestSharp")
from RestSharp import *
client = RestClient("https://www.google.com/")
restsharpResponse = client.Execute(RestRequest())
print(restsharpResponse.ErrorException.InnerException)>>> from clr import AddReference
PythonEngine.Initialize(): Runtime.Initialize()...
Runtime.Initialize(): Initialize types...
Runtime.Initialize(): Initialize types end.
Runtime.Initialize(): AssemblyManager.Initialize()...
Runtime.Initialize(): AssemblyManager.UpdatePath()...
PythonEngine.Initialize(): GetCLRModule()...
PythonEngine.Initialize(): clr GetManifestResourceStream...
>>> AddReference("RestSharp")
<System.Reflection.MonoAssembly object at 0x7f239e851438>
>>> from RestSharp import *
>>> client = RestClient("https://www.google.com/")
>>> restsharpResponse = client.Execute(RestRequest())
>>> print(restsharpResponse.ErrorException.InnerException)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'NoneType' object has no attribute 'InnerException'
>>> print(restsharpResponse.Content)
<!doctype html><html itemscope="" itemtype="http://schema.org/WebPage" lang="en"><head><meta content="Search the world's information, including webpages, images, videos and more. Google has many special features to help you find exactly what you're looking for." name="description"><meta content="noodp" ........

filmor · 2021-03-11T11:02:02Z

I think these are different config files. The current config_file is the global mono config from /etc/mono while the one that is neede d for mono_domain_set_config is supposed to be a local one (i.e. Your.App.dll.config). I suggest that we

Rename the current config_file to global_config_file
Use the config_file parameter for mono_domain_set_config

C-SELLERS · 2021-03-13T22:16:07Z

Ah I see what you mean, I was a bit confused because it was using ffi.NULL as the default, but I guess passing null to the mono_config_parse just loads in the default global config from the mono installation.

Certain features of the runtime like Dll remapping depend on a configuration file, to load the configuration file, just add:

mono_config_parse (NULL);

Which will load the Mono configuration file (typically /etc/mono/config)

I made the change and now it will use the config_file parameter for the domain configuration, and still maintain the default for mono's global config. 👍🏽

filmor · 2021-03-17T21:46:24Z

I adjusted the PR a bit, could you check whether this still works for you? Using an empty string has the advantage of being an invalid path name, so it can't accidentally load a dummy file that just happens to be located in the directory.

C-SELLERS · 2021-03-17T22:32:54Z

Just tested again with your changes. Working fine! 👍🏽

Thank you @filmor !

C-SELLERS added 3 commits March 10, 2021 11:47

set config for mono, dummy if none given

ada9c81

Encode config_file string

10ea444

byte literall string for config location

c80ac6a

Use config parameter for domain config

1fc4c0e

C-SELLERS changed the title ~~Mono Set Config~~ Mono Domain Set Config Mar 13, 2021

filmor added 2 commits March 17, 2021 22:34

Allow the global config path to be set

f3b58c3

Fix mono_config_parse call

8031c6e

filmor merged commit 4c35802 into pythonnet:master Mar 18, 2021

C-SELLERS mentioned this pull request Mar 23, 2021

Mono 'The 'ExeConfigFilename' argument cannot be null.' #8

Closed

C-SELLERS mentioned this pull request Apr 1, 2021

Bump to 0.1.6 #11

Closed

Martin-Molinero mentioned this pull request Apr 5, 2021

Update clr-loader and remove workaround QuantConnect/Lean#5451

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mono Domain Set Config #9

Mono Domain Set Config #9

C-SELLERS commented Mar 10, 2021

C-SELLERS commented Mar 10, 2021

filmor commented Mar 11, 2021

C-SELLERS commented Mar 13, 2021 •

edited

Loading

filmor commented Mar 17, 2021

C-SELLERS commented Mar 17, 2021

Mono Domain Set Config #9

Mono Domain Set Config #9

Conversation

C-SELLERS commented Mar 10, 2021

C-SELLERS commented Mar 10, 2021

filmor commented Mar 11, 2021

C-SELLERS commented Mar 13, 2021 • edited Loading

filmor commented Mar 17, 2021

C-SELLERS commented Mar 17, 2021

C-SELLERS commented Mar 13, 2021 •

edited

Loading