Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Source Link and symbol package generation during build #1259

Merged
merged 1 commit into from Oct 13, 2020

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Oct 12, 2020

What does this implement/fix? Explain your changes.

This enables Source Link and symbol package generation during build.

Source Link automatically pulls library (e.g. Python.NET) source code from GitHub when debugging.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@lostmsu lostmsu added this to In progress in Modernisation via automation Oct 12, 2020
@codecov-io
Copy link

Codecov Report

Merging #1259 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1259   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files           1        1           
  Lines         291      291           
=======================================
  Hits          251      251           
  Misses         40       40           
Flag Coverage Δ
#setup_linux 64.94% <ø> (ø)
#setup_windows 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a6909...f30107c. Read the comment docs.

@lostmsu lostmsu merged commit db30b87 into pythonnet:master Oct 13, 2020
Modernisation automation moved this from In progress to Done Oct 13, 2020
@lostmsu lostmsu deleted the PR/Symbols+Commit branch October 13, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Modernisation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants