Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .NET Core 3.1 LTS for tests (instead of 2.0) #1279

Merged
merged 1 commit into from Nov 13, 2020

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Nov 12, 2020

What does this implement/fix? Explain your changes.

.NET Core 2.0 is no longer supported. This moves tests to .NET Core 3.1 LTS, which should be supported until Dec 2022.

@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #1279 (13694d6) into master (d0c588b) will increase coverage by 1.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
+ Coverage   86.25%   87.62%   +1.37%     
==========================================
  Files           1        1              
  Lines         291      291              
==========================================
+ Hits          251      255       +4     
+ Misses         40       36       -4     
Flag Coverage Δ
setup_linux 64.94% <ø> (ø)
setup_windows 73.88% <ø> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 87.62% <ø> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c588b...13694d6. Read the comment docs.

@lostmsu
Copy link
Member Author

lostmsu commented Nov 13, 2020

Travis actually passed, but for some reason was not recorded correctly: https://travis-ci.org/github/pythonnet/pythonnet/builds/743309873

Since there are no functional changes, and tests still pass, I am going to merge this.

@lostmsu lostmsu merged commit 36bdb98 into pythonnet:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants