Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github actions workflow to replace travis #1307

Merged
merged 2 commits into from Dec 9, 2020

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Dec 8, 2020

Subj

This drops coverage for setup.py

@lostmsu lostmsu force-pushed the travis-github branch 13 times, most recently from 92dcfd5 to bc4585c Compare December 8, 2020 05:56
@lostmsu
Copy link
Member Author

lostmsu commented Dec 8, 2020

Either we:

  1. make our own docker images to test on (not sure how this works)
  2. have the build take 6+ minutes instead of 1 (remove Mono 6.12 and reinstall 5.20 instead)
  3. or switch Mono to 6.12 for testing

Considering we are doing a major version bump, we can pick option 3 for simplicity. @filmor thoughts?

@lostmsu lostmsu force-pushed the travis-github branch 2 times, most recently from 9db68a2 to 5379f53 Compare December 8, 2020 06:09
@filmor
Copy link
Member

filmor commented Dec 8, 2020

I'm in favour of just using the latest version.

@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #1307 (d47d388) into master (5b09ba6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1307   +/-   ##
=======================================
  Coverage   74.04%   74.04%           
=======================================
  Files           1        1           
  Lines         289      289           
=======================================
  Hits          214      214           
  Misses         75       75           
Flag Coverage Δ
setup_windows 74.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b09ba6...d47d388. Read the comment docs.

@lostmsu lostmsu requested a review from filmor December 9, 2020 00:53
@filmor filmor merged commit f8c27a1 into pythonnet:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants