Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match generic and private methods upon runtime reload #1637

Merged
merged 1 commit into from Dec 20, 2021

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Dec 18, 2021

What does this implement/fix? Explain your changes.

The old method matching code never worked for generic methods because their parameter types did not have assembly qualified names.

The new method explicitly checks generic parameters.

It also allows reloading of private methods, which can be exposed to Python via reflection or delegate binding.

Any other comments?

This is part of work to remove all shutdown modes (only Reload will remain), that ensures, that internal methods are always successfully reloaded.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Updated the CHANGELOG

@lostmsu lostmsu merged commit 332cae9 into pythonnet:master Dec 20, 2021
@lostmsu lostmsu deleted the ReloadMethodMatching branch December 20, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants