Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous fixes and cleanups #1760

Merged
merged 4 commits into from May 4, 2022
Merged

Miscellaneous fixes and cleanups #1760

merged 4 commits into from May 4, 2022

Conversation

filmor
Copy link
Member

@filmor filmor commented Apr 9, 2022

  • Use Py.GIL directly, now that it doesn't try to init anymore
  • Modernise syntax a bit
  • Fix Py.SetArgv for systems that don't support GetCommandLineArgs
  • Modernise syntax in ClassDerived

What does this implement/fix? Explain your changes.

...

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the .NET Foundation CLA
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

lostmsu
lostmsu reviewed Apr 9, 2022
View reviewed changes
src/runtime/Types/ClassBase.cs Outdated Show resolved Hide resolved
src/runtime/Types/EventObject.cs Outdated Show resolved Hide resolved
src/runtime/Types/PropertyObject.cs Outdated Show resolved Hide resolved
@filmor filmor merged commit 37f1235 into pythonnet:master May 4, 2022
@filmor filmor deleted the misc-fixes branch May 4, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostmsu lostmsu lostmsu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filmor @lostmsu