Min/MaxSupportedVersion and IsSupportedVersion on PythonEngine
#1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostmsu
force-pushed
the
SupportedVersions
branch
from
52a00c0
to
1492d7d
Compare
|
:/ I am puzzled. What does this change have to do with segfaults? Only on *nix? Ugh... |
filmor
reviewed
May 25, 2022
| @@ -127,6 +127,10 @@ public static string PythonPath | |||
| } | |||
| } | |||
|
|
|||
| public static Version MinSupportedVersion => new(3, 7); | |||
| public static Version MaxSupportedVersion => new(3, 10, int.MaxValue, int.MaxValue); | |||
There was a problem hiding this comment.
Maybe something more "readable", like 999 instead of maxint?
There was a problem hiding this comment.
I thought of that, but it won't work if there are builds of Python that use build number not as patch (e.g. patch .4), but in a Windows manner like .19041.365, or maybe do MaxSupportedVersionExclusive. Alternatively, we can only leave the IsSupportedVersion check and provide an error string in a separate property.
What do you think?
Just tested it as well, it only happens on Mono... |
|
Further observations:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this close any currently open issues?
fixes #1724
Checklist
Check all those that are applicable and complete.
CHANGELOG