Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-315 #316

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Issue-315 #316

merged 1 commit into from
Apr 1, 2024

Conversation

fsellaouti
Copy link
Contributor

fix #315

Copy link
Member

@fallen fallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good catch! Thanks!

However, by looking at your screenshot, it seems your fix does not translate some field labels.
Is that on purpose?

@fsellaouti
Copy link
Contributor Author

The other labels where already present on le .po file (footer field labels for example)

Copy link
Member

@fallen fallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks again :)

@fallen fallen merged commit 441a7b3 into pytition:master Apr 1, 2024
1 check passed
@fallen
Copy link
Member

fallen commented Apr 1, 2024

@fsellaouti Just out of pure curiosity: are you using Pytition? Do you host an instance yourself? Is it a public instance?
If the instance is public I can list it in the wiki :)

@fsellaouti
Copy link
Contributor Author

@fallen Indeed, we are hosting a public instance on https://petitions.pcf.fr/
Thanks for the work done si far

@fsellaouti fsellaouti deleted the issue-315 branch April 2, 2024 17:35
@fallen
Copy link
Member

fallen commented Apr 2, 2024

@fallen Indeed, we are hosting a public instance on https://petitions.pcf.fr/ Thanks for the work done si far

Very cool! Don't hesitate to contact me if you have any issue/feature request/feedback to improve Pytition :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation FR : Petition edit form labels
2 participants