-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 404 not found page #178
Conversation
Signed-off-by: afzal442 <afzal442@gmail.com>
✔️ Deploy Preview for code-generator ready! 🔨 Explore the source changes: d2bb320 🔍 Inspect the deploy log: https://app.netlify.com/sites/code-generator/deploys/615a7c4a92813900076680b2 😎 Browse the preview: https://deploy-preview-178--code-generator.netlify.app/ |
This comment has been minimized.
This comment has been minimized.
Thanks @afzal442! |
@afzal442 Looks like we have some linting issues here https://github.com/pytorch-ignite/code-generator/pull/178/checks?check_run_id=3781076007#step:9:13 Please take a look at our CONTRIBUTING how to run formatters. |
Thanks @afzal442 ! It works! But let's try to add top bar and a footer, to get smth like this: Inspired by pytorch 404 page |
Signed-off-by: afzal442 <afzal442@gmail.com>
@trsvchn I am done. 🪧 Plz also add |
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @afzal442 !
I left some nit comments related to wording.
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 afzal442@gmail.com
Description
Fix #170
Additional context
What is the purpose of this pull request?