Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional attributes #264

Merged

Conversation

theory-in-progress
Copy link
Contributor

  • train_epoch_length and eval_epoch_length have been set as optional according to engine definition

Made some of the attributes optional

Fix #233


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

- train_epoch_length and eval_epoch_length have been set as optional
	according to engine definition
@netlify
Copy link

netlify bot commented Jun 25, 2023

Deploy Preview for code-generator ready!

Name Link
🔨 Latest commit fc33113
🔍 Latest deploy log https://app.netlify.com/sites/code-generator/deploys/64987cd713aeb10008e03a22
😎 Deploy Preview https://deploy-preview-264--code-generator.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vfdev-5 vfdev-5 merged commit 9393a04 into pytorch-ignite:main Jun 26, 2023
20 checks passed
@theory-in-progress theory-in-progress deleted the feature-optional-params branch August 29, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's make train_epoch_length and eval_epoch_length optional
2 participants