Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated output config file to be same as config file #267

Merged
merged 6 commits into from
Jul 3, 2023

Conversation

theory-in-progress
Copy link
Contributor

Description

Updated the output config-lock.yaml to be the same as the user config file


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@netlify
Copy link

netlify bot commented Jul 1, 2023

Deploy Preview for code-generator ready!

Name Link
🔨 Latest commit 2e2bab6
🔍 Latest deploy log https://app.netlify.com/sites/code-generator/deploys/64a2cb770df76500088bf87e
😎 Deploy Preview https://deploy-preview-267--code-generator.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- Removed write_config_to_output_dir() function
- Uses shutil to write to the output dir
- Edited so that config-lock.yaml is copies after output_dir is created
@vfdev-5
Copy link
Member

vfdev-5 commented Jul 3, 2023

How about other templates ?

@theory-in-progress
Copy link
Contributor Author

Would these changes be ok? If so then I'll update it in the other templates too 👍

@vfdev-5
Copy link
Member

vfdev-5 commented Jul 3, 2023

Would these changes be ok? If so then I'll update it in the other templates too 👍

Seems ok

Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vfdev-5 vfdev-5 merged commit 46d3daa into pytorch-ignite:main Jul 3, 2023
20 checks passed
@theory-in-progress theory-in-progress deleted the update-log-config branch August 29, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants