Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit hash to the getZipUid function for PR Builds #319

Merged
merged 14 commits into from
Sep 19, 2023

Conversation

guptaaryan16
Copy link
Contributor

Description

This PR aims to improve the current behaviour of the CI for both the PR and deployment . As of now, we have a functionality where we try to create uuid for each configuration of the code generator app template and then return this using a getZIPUid function. This created a problem of not able to differentiate between the zip files and notebooks pushed for the PR Builds and the Deployment Builds.

We introduced a new netlify variable PR_BUILD which is false only when it is a production build. When the PR_BUILD=true, we are going to add the commit hash to the commit uuid generated by the getZipUid function.

Additional context

This issue was suggested in #317


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@guptaaryan16 guptaaryan16 marked this pull request as draft September 12, 2023 07:57
@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for code-generator ready!

Name Link
🔨 Latest commit 3694b26
🔍 Latest deploy log https://app.netlify.com/sites/code-generator/deploys/6509574af953df0008a05da9
😎 Deploy Preview https://deploy-preview-319--code-generator.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guptaaryan16 guptaaryan16 marked this pull request as ready for review September 19, 2023 08:28
Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @guptaaryan16 !

@guptaaryan16 guptaaryan16 merged commit e6d3710 into pytorch-ignite:main Sep 19, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants