-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commit hash to the getZipUid function for PR Builds #319
Merged
guptaaryan16
merged 14 commits into
pytorch-ignite:main
from
guptaaryan16:push_build_commit
Sep 19, 2023
Merged
Add commit hash to the getZipUid function for PR Builds #319
guptaaryan16
merged 14 commits into
pytorch-ignite:main
from
guptaaryan16:push_build_commit
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for code-generator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…into push_build_commit
vfdev-5
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @guptaaryan16 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve the current behaviour of the CI for both the PR and deployment . As of now, we have a functionality where we try to create
uuid
for each configuration of the code generator app template and then return this using agetZIPUid
function. This created a problem of not able to differentiate between the zip files and notebooks pushed for thePR Builds
and the Deployment Builds.We introduced a new netlify variable
PR_BUILD
which isfalse
only when it is a production build. When thePR_BUILD=true
, we are going to add the commit hash to the commit uuid generated by thegetZipUid
function.Additional context
This issue was suggested in #317
What is the purpose of this pull request?