Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use torch.nn.attention.sdpa_kernel #131

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

yanboliang
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2024
@yanboliang yanboliang requested a review from Chillee March 11, 2024 20:36
@Chillee
Copy link
Contributor

Chillee commented Mar 12, 2024

The main reason I didn't do this previously is worry that this'll cause the code to hard break on older versions. When was this new API added?

@yanboliang
Copy link
Contributor Author

It added two months ago (pytorch/pytorch@4e29f01). I understand the concern, don't have strong opinion on changing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants