Add inverse_permute argument to permute_1D_sparse_data #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D40521813 |
xing-liu
force-pushed
the
export-D40521813
branch
from
a179a90
to
85ad552
Compare
xing-liu
added a commit
to xing-liu/FBGEMM
that referenced
this pull request
Oct 24, 2022
Summary: Pull Request resolved: pytorch#1403 Variable batch size EC requires permute_1D backward. Add inverse_permute so we don't need to generate backward recat. Reviewed By: YazhiGao Differential Revision: D40521813 LaMa Project: L1138451 fbshipit-source-id: 92179093ac302bb3b794facfd3dde4491412058d
|
This pull request was exported from Phabricator. Differential Revision: D40521813 |
Summary: Pull Request resolved: pytorch#1403 Variable batch size EC requires permute_1D backward. Add inverse_permute so we don't need to generate backward recat. Reviewed By: YazhiGao Differential Revision: D40521813 LaMa Project: L1138451 fbshipit-source-id: 0f4a1b56ee92fafcec841bb3c9e14af26cced738
|
This pull request was exported from Phabricator. Differential Revision: D40521813 |
xing-liu
force-pushed
the
export-D40521813
branch
from
85ad552
to
3714170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Variable batch size EC requires permute_1D backward. Add inverse_permute so we don't need to generate backward recat.
Reviewed By: YazhiGao
Differential Revision:
D40521813
LaMa Project: L1138451