Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T145005253] Re-enable Tests for OSS PR Builds #1598

Closed
wants to merge 2 commits into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Feb 16, 2023

Summary:

  • Upgrade the FBGEMM_GPU release workflows to use the same build scripts framework for running the builds
  • Update the build scripts framework to properly support running PyTests
  • Disable certain tests from running in the CPU-only build as they are known to be failing at the moment (jagged_tensor_ops_test, uvm_test)
  • Update both the nightly and release jobs to actually run tests prior to publishing to PyPI
  • Fix bug with PyPI publishing for the FBGEMM_GPU-CPU nightly job
  • Update the nightly build cron schedules to follow PST
  • Remove some jobs from FBGEMM_GPU CI as they are now redundant with the FBGEMM_GPU nightly / release builds
  • Update the FBGEMM_GPU-CPU CI job (Ubuntu) to use the build scripts framework for building and running tests

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for pytorch-fbgemm-docs canceled.

Name Link
🔨 Latest commit 6d8590c
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/63f408ec76678f00086ad944

@q10 q10 force-pushed the bm/T145005253/build-scripts-2 branch 2 times, most recently from 61212e6 to 3fdf448 Compare February 18, 2023 02:28
- Upgrade the FBGEMM_GPU release workflows to use the same build scripts
framework for running the builds

- Update the build scripts framework to properly support running PyTests

- Disable certain tests from running in CPU mode as they are known to be
failing at the moment

- Update both the nightly and release jobs to actually run tests prior
to publishing to PyPI

- Fix bug with PyPI publishing for the FBGEMM_GPU-CPU nightly job

- Update the workflow cron schedules to follow PST
@q10 q10 force-pushed the bm/T145005253/build-scripts-2 branch from a121285 to 6327102 Compare February 20, 2023 23:35
- Remove some jobs from FBGEMM_GPU CI as they are now redundant with
the FBGEMM_GPU nightly / release builds

- Update the FBGEMM_GPU-CPU CI job (Ubuntu) to use the build scripts
framework for building and running tests
@q10 q10 force-pushed the bm/T145005253/build-scripts-2 branch from 6327102 to 6d8590c Compare February 20, 2023 23:57
@q10 q10 changed the title Bm/t145005253/build scripts 2 [T145005253] Re-enable Tests for OSS PR Builds Feb 21, 2023
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@brad-mengchi brad-mengchi self-requested a review February 21, 2023 21:28
@facebook-github-bot
Copy link
Contributor

@q10 merged this pull request in d142cdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants