[T145005253] Make Tests More Stable #1606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
q10
force-pushed
the
bm/T145005253/build-scripts-3
branch
8 times, most recently
from
3579cba
to
923f36c
Compare
- Add support for installing ROCm tooling in the build scripts framework - Update the existing FBGEMM_GPU CI / build_amd_gpu job
- Fix the annotations to tests in `jagged_tensor_ops_test.py` to run correctly on CPU-only mode
- Add support for retries in build steps that are known to fail due to the occasional network connection failures - Impose timeouts of 15 minutes for running the test suites (in practice, they generally complete within 3 minutes) - Add ability to conditionally disable tests depending on whether or not they are running inside the GitHub runner - Disable the `test_jagged_index_select_2d` test on GitHub until we figure out the root cause of it hanging whenever it is run on GitHub (regardless of GPU or CPU variant)
q10
force-pushed
the
bm/T145005253/build-scripts-3
branch
2 times, most recently
from
84f2141
to
1be5c4d
Compare
|
@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
brad-mengchi
approved these changes
Feb 26, 2023
- Consolidate ROCm testing under `run_fbgemm_gpu_tests` - Annotate bash variables with `local` keyword where applicable
q10
force-pushed
the
bm/T145005253/build-scripts-3
branch
from
1be5c4d
to
af195ad
Compare
|
@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
jagged_tensor_ops_test.pyto run correctly on CPU-only modetest_jagged_index_select_2dtest on GitHub until we figure out the root cause of it hanging whenever it is run on GitHub (regardless of GPU or CPU variant)