-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Weighted UVM Caching Stats Report #1623
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
This pull request was exported from Phabricator. Differential Revision: D43729139 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D43729139 |
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate. Differential Revision: D43729139 fbshipit-source-id: 2e6706ee125917036744b3f52f305cc03ca2b88f
dbcebfd
to
a0a90e7
Compare
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate. Differential Revision: D43729139 fbshipit-source-id: 27affced0a8ad94711c6f1bf6faee0898af76dd6
a0a90e7
to
32b9914
Compare
This pull request was exported from Phabricator. Differential Revision: D43729139 |
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate. Differential Revision: D43729139 fbshipit-source-id: de0823c6ff6651fdcdd933a36cecf5de161aaabc
32b9914
to
3c72db5
Compare
This pull request was exported from Phabricator. Differential Revision: D43729139 |
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate. Differential Revision: D43729139 fbshipit-source-id: 52dc5ba91eaf9650cd699bfbe31ee1fccd22fdc9
This pull request was exported from Phabricator. Differential Revision: D43729139 |
3c72db5
to
e81f8d6
Compare
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate. Differential Revision: D43729139 fbshipit-source-id: c4089b7fb5fb93586d389239bc694a346efa5222
e81f8d6
to
e36afd1
Compare
This pull request was exported from Phabricator. Differential Revision: D43729139 |
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause inaccurate cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we update the cache stats report using the weighted caching ratios by accumulating all the TBE's cache data within the same round of lookup call. Reviewed By: doehyun Differential Revision: D43729139 fbshipit-source-id: 0a889b9303bf5a5930bda0aed0cf642fc9e4d8a8
e36afd1
to
2bc1d5f
Compare
This pull request was exported from Phabricator. Differential Revision: D43729139 |
This pull request has been merged in 9e343d1. |
Summary: previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate.
Differential Revision: D43729139