Introduce Weighted UVM Caching Stats Report #1623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D43729139 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D43729139 |
YuzeDaiMeta
added a commit
to YuzeDaiMeta/FBGEMM
that referenced
this pull request
Mar 7, 2023
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate. Differential Revision: D43729139 fbshipit-source-id: 2e6706ee125917036744b3f52f305cc03ca2b88f
YuzeDaiMeta
force-pushed
the
export-D43729139
branch
from
dbcebfd
to
a0a90e7
Compare
YuzeDaiMeta
added a commit
to YuzeDaiMeta/FBGEMM
that referenced
this pull request
Mar 7, 2023
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate. Differential Revision: D43729139 fbshipit-source-id: 27affced0a8ad94711c6f1bf6faee0898af76dd6
YuzeDaiMeta
force-pushed
the
export-D43729139
branch
from
a0a90e7
to
32b9914
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43729139 |
YuzeDaiMeta
added a commit
to YuzeDaiMeta/FBGEMM
that referenced
this pull request
Mar 7, 2023
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate. Differential Revision: D43729139 fbshipit-source-id: de0823c6ff6651fdcdd933a36cecf5de161aaabc
YuzeDaiMeta
force-pushed
the
export-D43729139
branch
from
32b9914
to
3c72db5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43729139 |
YuzeDaiMeta
added a commit
to YuzeDaiMeta/FBGEMM
that referenced
this pull request
Mar 7, 2023
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate. Differential Revision: D43729139 fbshipit-source-id: 52dc5ba91eaf9650cd699bfbe31ee1fccd22fdc9
|
This pull request was exported from Phabricator. Differential Revision: D43729139 |
YuzeDaiMeta
force-pushed
the
export-D43729139
branch
from
3c72db5
to
e81f8d6
Compare
YuzeDaiMeta
added a commit
to YuzeDaiMeta/FBGEMM
that referenced
this pull request
Mar 7, 2023
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate. Differential Revision: D43729139 fbshipit-source-id: c4089b7fb5fb93586d389239bc694a346efa5222
YuzeDaiMeta
force-pushed
the
export-D43729139
branch
from
e81f8d6
to
e36afd1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43729139 |
Summary: Pull Request resolved: pytorch#1623 previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause inaccurate cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we update the cache stats report using the weighted caching ratios by accumulating all the TBE's cache data within the same round of lookup call. Reviewed By: doehyun Differential Revision: D43729139 fbshipit-source-id: 0a889b9303bf5a5930bda0aed0cf642fc9e4d8a8
YuzeDaiMeta
force-pushed
the
export-D43729139
branch
from
e36afd1
to
2bc1d5f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43729139 |
|
This pull request has been merged in 9e343d1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: previous cache stats report (e.g. cache miss rate, unique rate, etc) didn't take the number of requested indices of each TBE op into consideration, which could easily cause higher cache miss rate than the real situation, especially with unbalance-requested TBEs. Now we introduce the number of TBE ops into the UVMInfo and calculated the weighted unique rate, cache miss rate and conflict miss rate.
Differential Revision: D43729139