Refactor based on recent torch tensor view support #1816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D46585543 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Jun 9, 2023
Summary: Pull Request resolved: pytorch#1816 torch.view recently added reinterpret_cast dtype support: https://pytorch.org/docs/stable/generated/torch.Tensor.view.html Previously we have to rely on numpy, which introduces the extra H2D/D2H overhead. Differential Revision: D46585543 fbshipit-source-id: 63eb13341732d7f7c5d5d2448b7c577b94fd9e91
|
This pull request was exported from Phabricator. Differential Revision: D46585543 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Jun 9, 2023
Summary: Pull Request resolved: pytorch#1816 torch.view recently added reinterpret_cast dtype support: https://pytorch.org/docs/stable/generated/torch.Tensor.view.html Previously we have to rely on numpy, which introduces the extra H2D/D2H overhead. Differential Revision: D46585543 fbshipit-source-id: af3ddbf46559f6ff736c4158c2ba3b8f269601bc
|
This pull request was exported from Phabricator. Differential Revision: D46585543 |
Summary: Pull Request resolved: pytorch#1816 torch.view recently added reinterpret_cast dtype support: https://pytorch.org/docs/stable/generated/torch.Tensor.view.html Previously we have to rely on numpy, which introduces the extra H2D/D2H overhead. Reviewed By: sryap Differential Revision: D46585543 fbshipit-source-id: a1d4e792e61c15c71bb36d47a574d2c052e0a02f
|
This pull request was exported from Phabricator. Differential Revision: D46585543 |
|
This pull request has been merged in 1476a20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
torch.view recently added reinterpret_cast dtype support:
https://pytorch.org/docs/stable/generated/torch.Tensor.view.html
Previously we have to rely on numpy, which introduces the extra H2D/D2H overhead.
Differential Revision: D46585543