Block the combination of bf16 input and float output in EmbeddingSpMDM when running on Mac and Windows #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D47306447 |
excelle08
pushed a commit
to excelle08/FBGEMM
that referenced
this pull request
Jul 8, 2023
…M when running on Mac and Windows (pytorch#1865) Summary: Pull Request resolved: pytorch#1865 Block the combination of bfloat16 input and float32 output in EmbeddingSpMDM API when running on Mac and Windows. This is to prevent a random test failure. Reviewed By: q10 Differential Revision: D47306447 fbshipit-source-id: 061c1f4c561695317bdad8a05bb66fba7cc05fdf
excelle08
force-pushed
the
export-D47306447
branch
from
0b4d8d5
to
8f68902
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47306447 |
excelle08
pushed a commit
to excelle08/FBGEMM
that referenced
this pull request
Jul 9, 2023
…M when running on Mac and Windows (pytorch#1865) Summary: Pull Request resolved: pytorch#1865 Block the combination of bfloat16 input and float32 output in EmbeddingSpMDM API when running on Mac and Windows. This is to prevent a random test failure. Reviewed By: q10 Differential Revision: D47306447 fbshipit-source-id: 2eae1a7aa918237320c3387d6f21bde19ac3544a
excelle08
force-pushed
the
export-D47306447
branch
from
8f68902
to
06be363
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47306447 |
…M when running on Mac and Windows (pytorch#1865) Summary: Pull Request resolved: pytorch#1865 Block the combination of bfloat16 input and float32 output in EmbeddingSpMDM API when running on Mac and Windows. This is to prevent a random test failure. Reviewed By: q10 Differential Revision: D47306447 fbshipit-source-id: fe3cbd93495d4b5208685c3a501894987533c3f7
|
This pull request was exported from Phabricator. Differential Revision: D47306447 |
excelle08
force-pushed
the
export-D47306447
branch
from
06be363
to
cc3e9e1
Compare
|
This pull request has been merged in 372c62e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Block the combination of bfloat16 input and float32 output in EmbeddingSpMDM API when running on Mac and Windows. This is to prevent a random test failure.
Reviewed By: q10
Differential Revision: D47306447