Re-organize the backward split code generation, pt.2 #1873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 12, 2023
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Differential Revision: D47385306 fbshipit-source-id: a8f0fcb6a2dbf634c8ba70b8ecc24b6ca31bbb1a
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 12, 2023
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Differential Revision: D47385306 fbshipit-source-id: 778aff8c5c593a2d0d2ec16deb36b56c3546b6ed
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 13, 2023
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Differential Revision: D47385306 fbshipit-source-id: 9f40a36d39259f9a5baf888ae0fbd3b8a028e7d9
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 13, 2023
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Differential Revision: D47385306 fbshipit-source-id: 1e38f77489bbd36ad3f93a0ca88daa77d334942a
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 13, 2023
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Differential Revision: D47385306 fbshipit-source-id: ba6806af63d6913ab2bbfe191a87e3ced608467e
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 13, 2023
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Differential Revision: D47385306 fbshipit-source-id: 906e4892e1d304e00174b1ee91021d0dda896df7
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 13, 2023
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Differential Revision: D47385306 fbshipit-source-id: d9442f1d3b6810a227d586557a5a3587765ca2c4
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 13, 2023
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Differential Revision: D47385306 fbshipit-source-id: ed828eb421109407a8e923e1afa08fd431da4e39
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 13, 2023
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Reviewed By: sryap Differential Revision: D47385306 fbshipit-source-id: 8f8b9c033466e2ad3585ef20f0aa897af7594ec1
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 13, 2023
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Reviewed By: sryap Differential Revision: D47385306 fbshipit-source-id: 7fb6f02b900a0d1a82fd81b20e3abfcaad3a0e00
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
Summary: Pull Request resolved: pytorch#1873 - Use Jinja macros to simplify code generation in `embedding_backward_split_kernel_cta_template.cu` and `embedding_backward_split_kernel_warp_template.cu` - Update code generation of the kernel instantiations for the experimental optimizer cases Reviewed By: sryap Differential Revision: D47385306 fbshipit-source-id: 91c78e1857ea3996f9559f2c8c5f48e97ba2f1ac
|
This pull request was exported from Phabricator. Differential Revision: D47385306 |
|
This pull request has been merged in 9e24d2a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use Jinja macros to simplify code generation in
embedding_backward_split_kernel_cta_template.cuandembedding_backward_split_kernel_warp_template.cuUpdate code generation of the kernel instantiations for the experimental optimizer cases
Differential Revision: D47385306