-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TensorList in group_index_select_dim0 #1884
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
This pull request was exported from Phabricator. Differential Revision: D47488358 |
Summary: Pull Request resolved: pytorch#1884 Replace variadic template in `group_index_select_dim0` by packing all tensors into `TensorList` and passing the `TensorList` to autograd function. Return output needs to be tensors of the same size as input specified in the forward functions and can be returned as type of variable_list. This improves performance and lifts limitations of using variadic template that needs to be instantiated for each group size and limits max group size of 55. Reviewed By: sryap Differential Revision: D47488358 fbshipit-source-id: 7747896396e9acf3021bdabb9a054b6feb6c9038
3ec7144
to
ad5c45c
Compare
This pull request was exported from Phabricator. Differential Revision: D47488358 |
Summary: Pull Request resolved: pytorch#1884 Replace variadic template in `group_index_select_dim0` by packing all tensors into `TensorList` and passing the `TensorList` to autograd function. Return output needs to be tensors of the same size as input specified in the forward functions and can be returned as type of variable_list. This improves performance and lifts limitations of using variadic template that needs to be instantiated for each group size and limits max group size of 55. Reviewed By: sryap Differential Revision: D47488358 fbshipit-source-id: abf753560e462f19c7eebcb4ae7d7b47dcf700a2
ad5c45c
to
21686e8
Compare
This pull request was exported from Phabricator. Differential Revision: D47488358 |
Summary: Pull Request resolved: pytorch#1884 Replace variadic template in `group_index_select_dim0` by packing all tensors into `TensorList` and passing the `TensorList` to autograd function. Return output needs to be tensors of the same size as input specified in the forward functions and can be returned as type of variable_list. This improves performance and lifts limitations of using variadic template that needs to be instantiated for each group size and limits max group size of 55. Reviewed By: sryap Differential Revision: D47488358 fbshipit-source-id: 898f1d1a4ceb7183fc0ea00d78aa2983b10d0392
21686e8
to
5996c3e
Compare
This pull request was exported from Phabricator. Differential Revision: D47488358 |
Summary: Pull Request resolved: pytorch#1884 Replace variadic template in `group_index_select_dim0` by packing all tensors into `TensorList` and passing the `TensorList` to autograd function. Return output needs to be tensors of the same size as input specified in the forward functions and can be returned as type of variable_list. This improves performance and lifts limitations of using variadic template that needs to be instantiated for each group size and limits max group size of 55. Reviewed By: sryap Differential Revision: D47488358 fbshipit-source-id: 73e0b7e86c1981d9e73e87fc012c2f3b6c35efa8
5996c3e
to
acbc878
Compare
This pull request was exported from Phabricator. Differential Revision: D47488358 |
Summary: Pull Request resolved: pytorch#1884 Replace variadic template in `group_index_select_dim0` by packing all tensors into `TensorList` and passing the `TensorList` to autograd function. Return output needs to be tensors of the same size as input specified in the forward functions and can be returned as type of variable_list. This improves performance and lifts limitations of using variadic template that needs to be instantiated for each group size and limits max group size of 55. Reviewed By: sryap Differential Revision: D47488358 fbshipit-source-id: 574b6d4418069fb9e6b17d28484cf8796185a63b
acbc878
to
b2f81ff
Compare
This pull request was exported from Phabricator. Differential Revision: D47488358 |
This pull request has been merged in 8372bc7. |
Summary:
Replace variadic template in
group_index_select_dim0
by packing alltensors into
TensorList
and passing theTensorList
to autogradfunction. Return output needs to be tensors of the same size as
input specified in the forward functions and can be returned as
type of variable_list. This improves performance and lifts
limitations of using variadic template that needs to be instantiated
for each group size and limits max group size of 55.
Reviewed By: sryap
Differential Revision: D47488358