Add support for duplicate in permutations for permute_pooled_embs_split #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D48305847 |
|
This pull request was exported from Phabricator. Differential Revision: D48305847 |
AGZain
added a commit
to AGZain/FBGEMM
that referenced
this pull request
Aug 16, 2023
…it (pytorch#1940) Summary: Pull Request resolved: pytorch#1940 This diff builds ontop of the pervious diffs and adds support for duplicates to the permute_pooled_embs_split op. Background Currently permute_pooled_embs_split does not support duplicates in a permutation, this poses a problem with passing the same embeddings to multiple modules. This doc proposes a solution to allow duplicate subsets in the resultant permutation. Details The required implementation of permute_pooled_embs_split should support a subset being repeated. This is represented by having duplicates in the permute list. This also results in the output list size being greater than the input list. Input: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] Offset_dims: [0, 2, 5, 6, 10] Permute: [3, 0, 2, 1, 3] Output: [6, 7, 8, 9, 0, 1, 5, 2, 3, 4, 6, 7, 8, 9] Differential Revision: D48305847 fbshipit-source-id: 39c34e6f8533e49e5b0ad1847e77750f826f8569
AGZain
force-pushed
the
export-D48305847
branch
from
ce9fde7
to
6ecbf93
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48305847 |
AGZain
added a commit
to AGZain/FBGEMM
that referenced
this pull request
Aug 16, 2023
…it (pytorch#1940) Summary: Pull Request resolved: pytorch#1940 This diff builds ontop of the pervious diffs and adds support for duplicates to the permute_pooled_embs_split op. Background Currently permute_pooled_embs_split does not support duplicates in a permutation, this poses a problem with passing the same embeddings to multiple modules. This doc proposes a solution to allow duplicate subsets in the resultant permutation. Details The required implementation of permute_pooled_embs_split should support a subset being repeated. This is represented by having duplicates in the permute list. This also results in the output list size being greater than the input list. Input: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] Offset_dims: [0, 2, 5, 6, 10] Permute: [3, 0, 2, 1, 3] Output: [6, 7, 8, 9, 0, 1, 5, 2, 3, 4, 6, 7, 8, 9] Differential Revision: D48305847 fbshipit-source-id: 974bd1b76f29485974677f82754803e351f2e1c8
AGZain
force-pushed
the
export-D48305847
branch
from
6ecbf93
to
a018c94
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48305847 |
AGZain
added a commit
to AGZain/FBGEMM
that referenced
this pull request
Aug 18, 2023
…it (pytorch#1940) Summary: Pull Request resolved: pytorch#1940 This diff builds ontop of the pervious diffs and adds support for duplicates to the permute_pooled_embs_split op. Background Currently permute_pooled_embs_split does not support duplicates in a permutation, this poses a problem with passing the same embeddings to multiple modules. This doc proposes a solution to allow duplicate subsets in the resultant permutation. Details The required implementation of permute_pooled_embs_split should support a subset being repeated. This is represented by having duplicates in the permute list. This also results in the output list size being greater than the input list. Input: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] Offset_dims: [0, 2, 5, 6, 10] Permute: [3, 0, 2, 1, 3] Output: [6, 7, 8, 9, 0, 1, 5, 2, 3, 4, 6, 7, 8, 9] Differential Revision: D48305847 fbshipit-source-id: d3776869860ca4254a69bd7079061e737e2c0857
AGZain
force-pushed
the
export-D48305847
branch
from
a018c94
to
29daf29
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48305847 |
AGZain
added a commit
to AGZain/FBGEMM
that referenced
this pull request
Aug 18, 2023
…it (pytorch#1940) Summary: Pull Request resolved: pytorch#1940 This diff builds ontop of the pervious diffs and adds support for duplicates to the permute_pooled_embs_split op. Background Currently permute_pooled_embs_split does not support duplicates in a permutation, this poses a problem with passing the same embeddings to multiple modules. This doc proposes a solution to allow duplicate subsets in the resultant permutation. Details The required implementation of permute_pooled_embs_split should support a subset being repeated. This is represented by having duplicates in the permute list. This also results in the output list size being greater than the input list. Input: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] Offset_dims: [0, 2, 5, 6, 10] Permute: [3, 0, 2, 1, 3] Output: [6, 7, 8, 9, 0, 1, 5, 2, 3, 4, 6, 7, 8, 9] Differential Revision: D48305847 fbshipit-source-id: 39b3eaea63a1b4efd2c392425586f10fe2d0c6fa
AGZain
force-pushed
the
export-D48305847
branch
from
29daf29
to
ef2e705
Compare
…it (pytorch#1940) Summary: This diff builds ontop of the pervious diffs and adds support for duplicates to the permute_pooled_embs_split op. Background Currently permute_pooled_embs_split does not support duplicates in a permutation, this poses a problem with passing the same embeddings to multiple modules. This doc proposes a solution to allow duplicate subsets in the resultant permutation. Details The required implementation of permute_pooled_embs_split should support a subset being repeated. This is represented by having duplicates in the permute list. This also results in the output list size being greater than the input list. Input: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] Offset_dims: [0, 2, 5, 6, 10] Permute: [3, 0, 2, 1, 3] Output: [6, 7, 8, 9, 0, 1, 5, 2, 3, 4, 6, 7, 8, 9] Reviewed By: sryap Differential Revision: D48305847
AGZain
force-pushed
the
export-D48305847
branch
from
ef2e705
to
d0d153d
Compare
AGZain
pushed a commit
to AGZain/FBGEMM
that referenced
this pull request
Sep 18, 2023
…it (pytorch#1940) Summary: This diff builds ontop of the pervious diffs and adds support for duplicates to the permute_pooled_embs_split op. Background Currently permute_pooled_embs_split does not support duplicates in a permutation, this poses a problem with passing the same embeddings to multiple modules. This doc proposes a solution to allow duplicate subsets in the resultant permutation. Details The required implementation of permute_pooled_embs_split should support a subset being repeated. This is represented by having duplicates in the permute list. This also results in the output list size being greater than the input list. Input: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] Offset_dims: [0, 2, 5, 6, 10] Permute: [3, 0, 2, 1, 3] Output: [6, 7, 8, 9, 0, 1, 5, 2, 3, 4, 6, 7, 8, 9] Reviewed By: sryap Differential Revision: D48305847
|
This pull request was exported from Phabricator. Differential Revision: D48305847 |
AGZain
force-pushed
the
export-D48305847
branch
from
d0d153d
to
886e065
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48305847 |
|
This pull request has been merged in f030bbc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff builds ontop of the pervious diffs and adds support for duplicates to the permute_pooled_embs_split op.
Background
Currently permute_pooled_embs_split does not support duplicates in a permutation, this poses a problem with passing the same embeddings to multiple modules. This doc proposes a solution to allow duplicate subsets in the resultant permutation.
Details
The required implementation of permute_pooled_embs_split should support a subset being repeated. This is represented by having duplicates in the permute list. This also results in the output list size being greater than the input list.
Input: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
Offset_dims: [0, 2, 5, 6, 10]
Permute: [3, 0, 2, 1, 3]
Output: [6, 7, 8, 9, 0, 1, 5, 2, 3, 4, 6, 7, 8, 9]
Differential Revision: D48305847