Use Nova workflow to host all published wheel files at PyTorch site #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D48487102 |
|
This pull request was exported from Phabricator. Differential Revision: D48487102 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Aug 19, 2023
…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 2c09e5063307207c45cefe96c1fe5d8f33a51bc1
spcyppt
force-pushed
the
export-D48487102
branch
from
f573c22
to
a700dae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48487102 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Aug 19, 2023
…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 3baeedad2fd554b63267eaf6ea6023a01f787de5
spcyppt
force-pushed
the
export-D48487102
branch
from
a700dae
to
076278f
Compare
osalpekar
reviewed
Aug 19, 2023
Comment on lines
28
to
29
| pre-script: .github/script/nova_prescript.bash | ||
| post-script: .github/script/nova_prescript.bash |
There was a problem hiding this comment.
Should be .github/scripts instead of .github/script. This looks like the cause of the current breakage.
There was a problem hiding this comment.
Thank you for catching that! I have fixed it.
| ref: "" | ||
| pre-script: .github/script/nova_prescript.bash | ||
| post-script: .github/script/nova_prescript.bash | ||
| smoke-test-script: |
There was a problem hiding this comment.
Let's explicitly make the value passed to this arg be ""
.github/scripts/nova_prescript.bash
Outdated
Comment on lines
18
to
21
| #Install CUDA | ||
| $PRELUDE; install_cuda $BUILD_ENV "$CU_VERSION" | ||
| # Install PyTorch Nightly | ||
| $PRELUDE; install_pytorch_pip $BUILD_ENV nightly cuda "$CU_VERSION" |
There was a problem hiding this comment.
CUDA and the right pytorch version should already be installed for you under the hood by our pipeline, there is no need to do so in your pre-script.
There was a problem hiding this comment.
Thank you so much, I've removed them.
|
This pull request was exported from Phabricator. Differential Revision: D48487102 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Aug 19, 2023
…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 6464b7832f50502c2b4925cea5b5cb62b3880611
spcyppt
force-pushed
the
export-D48487102
branch
from
076278f
to
cd0f731
Compare
|
HI @spcyppt please fix this failure: https://github.com/pytorch/FBGEMM/actions/runs/5908914110/job/16028907266?pr=1958 |
|
This pull request was exported from Phabricator. Differential Revision: D48487102 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Aug 21, 2023
…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 2a468a86c430399be26f13de114e45c5062b7526
spcyppt
force-pushed
the
export-D48487102
branch
from
cd0f731
to
0a48dec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48487102 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Aug 21, 2023
…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 185f3963e6b8ea4b7daa82f50bb055b8da6bf5b9
spcyppt
force-pushed
the
export-D48487102
branch
from
0a48dec
to
8425266
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48487102 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Aug 21, 2023
…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 06704724ad1e4f3be8a24146912823195c33998d
spcyppt
force-pushed
the
export-D48487102
branch
from
8425266
to
06138c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48487102 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Aug 21, 2023
…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: ce52bd616e60baf1a2e3077f02b57073538b6b6b
spcyppt
force-pushed
the
export-D48487102
branch
from
06138c3
to
2207160
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48487102 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Aug 21, 2023
…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 78af627fe2bafc777d4abc52172ea83e46b192a4
spcyppt
force-pushed
the
export-D48487102
branch
from
2207160
to
3c27900
Compare
…into export-D48487102
…into export-D48487102
…into export-D48487102
…into export-D48487102
…into export-D48487102
…into export-D48487102
…into export-D48487102
…into export-D48487102
…into export-D48487102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead.
#1947
Differential Revision: D48487102