Add variable batch per feature support to EBC (tw/cw only) #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Aug 30, 2023
) Summary: Pull Request resolved: pytorch#1358 X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and reverse_indices to the KJT Reindexing is done internally with EBC and with a user provided reverse indices tensor Differential Revision: D48805440 fbshipit-source-id: 3f9439b0ca5325489fcf9c629bffe95da53ece9c
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Aug 30, 2023
) Summary: X-link: pytorch/torchrec#1358 Pull Request resolved: pytorch#1986 To enable provide stride_per_key_per_rank and reverse_indices to the KJT Reindexing is done internally with EBC and with a user provided reverse indices tensor Differential Revision: D48805440 fbshipit-source-id: 504f1dd0ebe0c2de28fe4d2bc623e3ba3b4da69a
joshuadeng
force-pushed
the
export-D48805440
branch
from
fbaa36f
to
108d23e
Compare
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Aug 30, 2023
) Summary: Pull Request resolved: pytorch#1358 X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and reverse_indices to the KJT Reindexing is done internally with EBC and with a user provided reverse indices tensor Differential Revision: D48805440 fbshipit-source-id: 2cb3665209025a44e659e5277534ad3f9e41ae0d
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Aug 30, 2023
) Summary: X-link: pytorch/torchrec#1358 Pull Request resolved: pytorch#1986 To enable provide stride_per_key_per_rank and reverse_indices to the KJT Reindexing is done internally with EBC and with a user provided reverse indices tensor Differential Revision: D48805440 fbshipit-source-id: ded203e36f575e3ffb8a5b04591a1891bdccc1bc
joshuadeng
force-pushed
the
export-D48805440
branch
from
108d23e
to
4c9fdb4
Compare
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Aug 30, 2023
) Summary: Pull Request resolved: pytorch#1358 X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and reverse_indices to the KJT Reindexing is done internally with EBC and with a user provided reverse indices tensor Differential Revision: D48805440 fbshipit-source-id: b151328e3d2e8ec6cae4f235db505d9a3a70e3fd
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Aug 31, 2023
) Summary: X-link: pytorch/torchrec#1358 Pull Request resolved: pytorch#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with a user provided inverse indices tensor we provide a utility function `merge_inverse_indices_per_key` to convert inverse indices in format `Dict[str, torch.Tensor]` to `torch.Tensor` accepted by KJT constructor Differential Revision: D48805440 fbshipit-source-id: cf889a87ab0f516897a7476268f321a97db079b5
joshuadeng
force-pushed
the
export-D48805440
branch
from
4c9fdb4
to
ac098ad
Compare
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Aug 31, 2023
) Summary: Pull Request resolved: pytorch#1358 X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with a user provided inverse indices tensor we provide a utility function `merge_inverse_indices_per_key` to convert inverse indices in format `Dict[str, torch.Tensor]` to `torch.Tensor` accepted by KJT constructor Differential Revision: D48805440 fbshipit-source-id: f66d4ec17457780922d8d63a8b71d45bd272c535
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Sep 2, 2023
) Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with a user provided inverse indices tensor we provide a utility function `merge_inverse_indices_per_key` to convert inverse indices in format `Dict[str, torch.Tensor]` to `torch.Tensor` accepted by KJT constructor Differential Revision: D48805440
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Sep 2, 2023
) Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with a user provided inverse indices tensor we provide a utility function `merge_inverse_indices_per_key` to convert inverse indices in format `Dict[str, torch.Tensor]` to `torch.Tensor` accepted by KJT constructor Differential Revision: D48805440
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
force-pushed
the
export-D48805440
branch
from
ac098ad
to
6f0abb0
Compare
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Oct 9, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Differential Revision: D48805440
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Oct 9, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Differential Revision: D48805440
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Oct 9, 2023
) Summary: Pull Request resolved: pytorch#1358 X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with a user provided inverse indices tensor we provide a utility function `merge_inverse_indices_per_key` to convert inverse indices in format `Dict[str, torch.Tensor]` to `torch.Tensor` accepted by KJT constructor Differential Revision: https://internalfb.com/D48805440 fbshipit-source-id: ae10bfae756a278c80be01f803176280215eb809
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Oct 10, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Differential Revision: D48805440
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Oct 12, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Differential Revision: D48805440
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: pytorch#1358 X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Differential Revision: https://internalfb.com/D48805440 fbshipit-source-id: 227aa80bc7aca187e96c131305cc185790df0ee8
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/torchrec#1358 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/torchrec#1358 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/torchrec#1358 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/torchrec#1358 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/torchrec#1358 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Nov 20, 2023
Summary: X-link: pytorch/torchrec#1358 Pull Request resolved: pytorch#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440 fbshipit-source-id: 9f49f7789ea2a20344cc56f84018fc761892836d
Summary: X-link: pytorch/torchrec#1358 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440
|
This pull request was exported from Phabricator. Differential Revision: D48805440 |
|
This pull request has been merged in 54340d4. |
facebook-github-bot
pushed a commit
to pytorch/torchrec
that referenced
this pull request
Nov 20, 2023
Summary: Pull Request resolved: #1358 X-link: pytorch/FBGEMM#1986 To enable provide stride_per_key_per_rank and inverse_indices to the KJT Reindexing is done internally with EBC and with user provided inverse indices Reviewed By: bigning Differential Revision: D48805440 fbshipit-source-id: e490baa41b9c91b02e6c246940d4a3a2c4551d65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To enable provide stride_per_key_per_rank and reverse_indices to the KJT
Reindexing is done internally with EBC and with a user provided reverse indices tensor
Differential Revision: D48805440