Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- SymInts for pack_segments meta function #2017

Closed
wants to merge 1 commit into from
Closed

- SymInts for pack_segments meta function #2017

wants to merge 1 commit into from

Conversation

flaviotruzzi
Copy link
Contributor

Summary: Add SymInts for pack_segments

Differential Revision: D48712041

@netlify
Copy link

netlify bot commented Sep 14, 2023 •
edited
Loading

✅ Deploy Preview for pytorch-fbgemm-docs canceled.

Name Link
🔨 Latest commit e07aceb
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/650b53468b45280008844a08

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

anijain2305
anijain2305 reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I have limited knowledge about this.

cc @bdhirsh @ezyang @rzou

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 14, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
19b9dfc 
Summary:

Add SymInts for pack_segments

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 14, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
809ba24 
Summary:

Add SymInts for pack_segments

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 14, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
c87941c 
Summary:

Add SymInts for pack_segments

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 19, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
eabb043 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 19, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
bcc8236 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 19, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
cf97308 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 19, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
da32abd 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 19, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
6eb84a3 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 19, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
b6f6229 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 20, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
0a1bf1a 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 20, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
11ff818 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 20, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
c347a93 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

flaviotruzzi pushed a commit to flaviotruzzi/FBGEMM that referenced this pull request Sep 20, 2023
@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
3c0fff7 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

@facebook-github-bot
- SymInts for pack_segments meta function (pytorch#2017)
e07aceb 
Summary:

Add SymInts for pack_segments

Reviewed By: ezyang, xw285cornell

Differential Revision: D48712041
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48712041

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a511f9d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anijain2305 anijain2305 anijain2305 left review comments

@bdhirsh bdhirsh bdhirsh approved these changes

Assignees
No one assigned
Labels
cla signed fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flaviotruzzi @facebook-github-bot @anijain2305 @bdhirsh