Add aarch64 builds on Nova #2024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D49333436 |
osalpekar
approved these changes
Sep 15, 2023
| - repository: pytorch/FBGEMM | ||
| smoke-test-script: "" | ||
| pre-script: ../.github/scripts/nova_prescript.bash | ||
| post-script: ../.github/scripts/nova_postscript.bash\ |
There was a problem hiding this comment.
nit: remove trailing \. also don't need the ../ since it starts looking in the project root directory
There was a problem hiding this comment.
I force cd fbgemm_gpu in env-var-script if it's in project root directory. Will the script gets read before or after the env-var-script is executed?
Edit: seems like it runs after. I get it to work. Thank you!
|
This pull request was exported from Phabricator. Differential Revision: D49333436 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: pytorch#2024 Add arm builds through Nova to be hosted on pytorch.org Reviewed By: osalpekar Differential Revision: D49333436 fbshipit-source-id: 09e4c57a53fba9c8268e0fb8a94fed8e71b2d326
spcyppt
force-pushed
the
export-D49333436
branch
from
1cd106c
to
ab4f544
Compare
Differential Revision: D49329679 fbshipit-source-id: 227fda11445355998bb1d48da1244119e7923c49
Summary: Pull Request resolved: pytorch#2024 Add arm builds through Nova to be hosted on pytorch.org Reviewed By: osalpekar Differential Revision: D49333436 fbshipit-source-id: af8efdc2b98e8b109f4f94d69842f67ae6bfdc1b
|
This pull request was exported from Phabricator. Differential Revision: D49333436 |
spcyppt
force-pushed
the
export-D49333436
branch
from
ab4f544
to
de1c0de
Compare
|
This pull request has been merged in bc0b58d. |
spcyppt
added a commit
that referenced
this pull request
Sep 18, 2023
Summary: Pull Request resolved: #2024 Add arm builds through Nova to be hosted on pytorch.org Reviewed By: osalpekar Differential Revision: D49333436 fbshipit-source-id: 5d8c192afe10db5ed9b5c6bb35f823d66794e81a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add arm builds through Nova to be hosted on pytorch.org
Differential Revision: D49333436