- Support for CPU/GPU compilation #2040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D49615498 |
flaviotruzzi
pushed a commit
to flaviotruzzi/FBGEMM
that referenced
this pull request
Sep 25, 2023
Summary: Backwards was not working for CPU. Moving the Autograd registration to CPU fixes the issue. On CPU only compilation since the GPU code was not built there was no autograd registration. Also re-activated the test on github. Differential Revision: D49615498
flaviotruzzi
force-pushed
the
export-D49615498
branch
from
71a5e86
to
6eb30f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49615498 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49615498 |
flaviotruzzi
pushed a commit
to flaviotruzzi/FBGEMM
that referenced
this pull request
Sep 25, 2023
Summary: Backwards was not working for CPU. Moving the Autograd registration to CPU fixes the issue. On CPU only compilation since the GPU code was not built there was no autograd registration. Also re-activated the test on github. Reviewed By: spcyppt Differential Revision: D49615498
flaviotruzzi
force-pushed
the
export-D49615498
branch
from
6eb30f5
to
35e3fdf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49615498 |
flaviotruzzi
pushed a commit
to flaviotruzzi/FBGEMM
that referenced
this pull request
Sep 25, 2023
Summary: Backwards was not working for CPU. Moving the Autograd registration to CPU fixes the issue. On CPU only compilation since the GPU code was not built there was no autograd registration. Also re-activated the test on github. Reviewed By: spcyppt Differential Revision: D49615498
flaviotruzzi
force-pushed
the
export-D49615498
branch
from
35e3fdf
to
439292a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49615498 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49615498 |
Summary: Backwards was not working for CPU. Moving the Autograd registration to CPU fixes the issue. On CPU only compilation since the GPU code was not built there was no autograd registration. Also re-activated the test on github. Reviewed By: spcyppt Differential Revision: D49615498
flaviotruzzi
force-pushed
the
export-D49615498
branch
from
439292a
to
59cc595
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49615498 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49615498 |
|
This pull request has been merged in 9b681e5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Backwards was not working for CPU.
Moving the Autograd registration to CPU fixes the issue. On CPU only compilation since the GPU code was not built there was no autograd registration.
Also re-activated the test on github.
Differential Revision: D49615498