simplify Hip.cmake and prepare for the future ROCm versions #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
No ciflow labels are configured for this repo. |
|
@shintaro-iwasaki has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks! Looks good to me. Let me merge it. |
|
@shintaro-iwasaki merged this pull request in df8d189. |
liligwu
added a commit
to ROCm/FBGEMM
that referenced
this pull request
Jan 17, 2024
…2106) Summary: Pull Request resolved: pytorch#2106 Reviewed By: q10 Differential Revision: D50938407 Pulled By: shintaro-iwasaki fbshipit-source-id: 59598292b1caceeccaddf5c19f3639766d5a09d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.