Remove test_aot_dispatch_static* tests from opcheck tests #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D51051732 |
zou3519
added a commit
to zou3519/FBGEMM
that referenced
this pull request
Nov 7, 2023
Summary: We missed a line in the original diff. After Ed's D50886564, test_aot_dispatch_static and test_aot_dispatch_dynamic are redundant, so we're just going to go with one of them to reduce complexity and overall test times. Reviewed By: williamwen42 Differential Revision: D51051732
zou3519
force-pushed
the
export-D51051732
branch
from
28a9fc2
to
3158354
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51051732 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51051732 |
Summary: We missed a line in the original diff. After Ed's D50886564, test_aot_dispatch_static and test_aot_dispatch_dynamic are redundant, so we're just going to go with one of them to reduce complexity and overall test times. Reviewed By: williamwen42 Differential Revision: D51051732
zou3519
force-pushed
the
export-D51051732
branch
from
3158354
to
173808d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51051732 |
|
This pull request has been merged in b8f6beb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We missed a line in the original diff.
After Ed's D50886564, test_aot_dispatch_static and
test_aot_dispatch_dynamic are redundant, so we're just going to go with one
of them to reduce complexity and overall test times.
Differential Revision: D51051732