Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add early exit in sparse_async_cumsum op #2213

Closed
wants to merge 1 commit into from

Conversation

meremeev
Copy link

Summary: This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

Differential Revision: D52155358

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 3862b68
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/659f7da2d655a20008d34391
😎 Deploy Preview https://deploy-preview-2213--pytorch-fbgemm-docs.netlify.app/fbgemm_gpu-python-api/table_batched_embedding_ops
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Dec 14, 2023
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Dec 14, 2023
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Dec 15, 2023
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

This is reworked version of previous diff D51999938 which failed some tests -  
https://www.internalfb.com/intern/test/281475091287900/
and has been reverted ( D52099677 )

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Dec 18, 2023
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

This is reworked version of previous diff D51999938 which failed some tests -  
https://www.internalfb.com/intern/test/281475091287900/
and has been reverted ( D52099677 )

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Dec 18, 2023
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

This is reworked version of previous diff D51999938 which failed some tests -  
https://www.internalfb.com/intern/test/281475091287900/
and has been reverted ( D52099677 )

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Dec 19, 2023
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

This is reworked version of previous diff D51999938 which failed some tests -  
https://www.internalfb.com/intern/test/281475091287900/
and has been reverted ( D52099677 )

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Dec 19, 2023
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

This is reworked version of previous diff D51999938 which failed some tests -  
https://www.internalfb.com/intern/test/281475091287900/
and has been reverted ( D52099677 )

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Jan 9, 2024
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

This is reworked version of previous diff D51999938 which failed some tests -  
https://www.internalfb.com/intern/test/281475091287900/
and has been reverted ( D52099677 )

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Jan 9, 2024
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

This is reworked version of previous diff D51999938 which failed some tests -  
https://www.internalfb.com/intern/test/281475091287900/
and has been reverted ( D52099677 )

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Jan 9, 2024
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

This is reworked version of previous diff D51999938 which failed some tests -  
https://www.internalfb.com/intern/test/281475091287900/
and has been reverted ( D52099677 )

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

meremeev pushed a commit to meremeev/FBGEMM that referenced this pull request Jan 10, 2024
Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

This is reworked version of previous diff D51999938 which failed some tests -  
https://www.internalfb.com/intern/test/281475091287900/
and has been reverted ( D52099677 )

Reviewed By: jasonjk-park

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

Summary:

This diff adds an early exit in sparse_async_cumsum ops. When the size(s) of input tensor are zeor(s) ops return zero tensor.

This is reworked version of previous diff D51999938 which failed some tests -  
https://www.internalfb.com/intern/test/281475091287900/
and has been reverted ( D52099677 )

Reviewed By: jasonjk-park

Differential Revision: D52155358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52155358

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5300974.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants